These changes are all great, merged, thanks @thedeveloperr!

How close are we to finishing this effort?

@timabbott

1. Few log verify are causing failures which I can't figure out why they are happening
2. I noticed few new spam which was not coming before I started this, I am not sure why this new spam is coming now and not before, maybe buffering issue in stdout, stderr ? I will check it

test: Running zerver.tests.test_logging_handlers.RateLimitFilterTest.test_recursive_filter_handling
 spam: 2020-07-23 06:11:50.989 ERR  [] Log an error to trigger recursive filter() calls in _RateLimitFilter.

2020-07-23 06:11:50.989 ERR  [] Log an error to trigger initial _RateLimitFilter.filter() call.

test: Running zerver.tests.test_push_notifications.PushBouncerNotificationTest.test_push_bouncer_api
 spam: 2020-07-23 06:13:04.687 ERR  [django.request] Bad Gateway: /json/users/me/apns_device_token

2020-07-23 06:13:04.703 ERR  [django.request] Bad Gateway: /json/users/me/apns_device_token

2020-07-23 06:13:04.753 ERR  [django.request] Bad Gateway: /json/users/me/android_gcm_reg_id

2020-07-23 06:13:04.766 ERR  [django.request] Bad Gateway: /json/users/me/android_gcm_reg_id

These are the stuff which i am not able to solve right now

@timabbott 14 more spam found (few of them just started appearing in the output, they were not appearing before) I think 1 or 2 day more. The slowest step in doing this is running the test again and again. Running single module test is not enough because single module produces different spam and that spam doesn't appear when running test for all modules.
Also some extra spam comes when parallel flag have value > 1

For zerver.tests.test_push_notifications.PushBouncerNotificationTest.test_push_bouncer_api, I'll just do a quick fix; it's just a loop: 4a7eb47.

@mateuszmandera may be able to help with adding an appropriate assertLogs for test_recursive_filter_handling.

Some spam may be nondeterministic; happy to help figure out a plan for any of those. But I'm excited we're close!

For zerver.tests.test_push_notifications.PushBouncerNotificationTest.test_push_bouncer_api, I'll just do a quick fix; it's just a loop: 4a7eb47.

@timabbott I made a similar fix but it was failing sometimes. I am not sure why. 9861937

It's possible the issue is the way you nested things? I guess we'll see if the version I did fails; I wouldn't expect it to.