New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "Alert words" view to left sidebar #28778

Open

Tracked by

alya opened this issue Jan 31, 2024 · 3 comments · May be fixed by #28858

Open

Tracked by

Add "Alert words" view to left sidebar #28778

alya opened this issue Jan 31, 2024 · 3 comments · May be fixed by #28858

Labels

area: left sidebar (features) difficult help wanted new feature

Contributor

alya commented Jan 31, 2024 •

edited

Loading

We should add a dedicated "Alert words" view in the left sidebar, equivalent to the "is:alerted" search filter.

Notes:

It should have an unread counter. This is the hardest part, and will require an API discussion.
Placement:
- Just below @-mentions in the expanded view
- In the ... menu in the collapsed view (first item)
- Hidden altogether if the user has no alert words configured. (But shown if alert words are configured, but there are no messages with alert words to show. Empty text: "You have no messages with alert words.")
The view should have a ... menu with an "Alert words settings" link to /#settings/alert-words. A gear icon should be OK for this menu item.
TBD: icon for left sidebar and view heading

These changes will need to be documented in the help center; this can be a follow-up.

The text was updated successfully, but these errors were encountered:

alya added help wanted difficult new feature area: left sidebar (features) labels

This was referenced Jan 31, 2024

Alert words are not shown in @ Mentions #15761

Open

Improve alert words #28779

Open

Collaborator

roanster007 commented Feb 2, 2024

@zulipbot claim

zulipbot assigned roanster007

zulipbot added the in progress label

roanster007 added a commit to roanster007/zulip that referenced this issue


          left_sidebar_nav_area: Refactor handle_narrow_activated filter_name.

c995636

This commit refactors the handle_narrow_activated method of
the left_sidebar_navigation_area to use a switch case instead
of an if-else in the filter_name.

This is a preparatory commit for zulip#28778.

roanster007 added a commit to roanster007/zulip that referenced this issue


          left_sidebar: Add Alerts views.

2e283f5

This commit adds a new Alerts view to the left sidebar, clicking
on which narrows to "is: alerted" messages. This view is only
present when the user has chosen some alert words

It adds 3 dot menu to it linking to the Alert word settings.

It also adds the Alerts view to the condensed view.

Fixes part of zulip#28778.

roanster007 added a commit to roanster007/zulip that referenced this issue


          left_sidebar: Add unread counts to the Alert Views.

b307a8b

This commit adds the unread counts to the Alert Views, both in
condensed and non condensed state.

Fixes: zulip#28778

roanster007 linked a pull request

that will close this issue

left_sidebar: Add Alerts View to the left sidebar. #28858

Open

12 tasks

roanster007 added a commit to roanster007/zulip that referenced this issue


          left_sidebar: Add unread counts to the Alert Views.

0006e37

This commit adds the unread counts to the Alert Views, both in
condensed and non condensed state.

Fixes: zulip#28778

roanster007 added a commit to roanster007/zulip that referenced this issue


          left_sidebar: Add unread counts to the Alert Views.

4b54af3

This commit adds the unread counts to the Alert Views, both in
condensed and non condensed state.

Fixes: zulip#28778.

roanster007 added a commit to roanster007/zulip that referenced this issue


          left_sidebar_nav_area: Refactor handle_narrow_activated filter_name.

44e98de

This commit refactors the handle_narrow_activated method of
the left_sidebar_navigation_area to use a switch case instead
of an if-else in the filter_name.

This is a preparatory commit for zulip#28778.

roanster007 added a commit to roanster007/zulip that referenced this issue


          left_sidebar: Add Alerts views.

8e1c661

This commit adds a new Alerts view to the left sidebar, clicking
on which narrows to "is: alerted" messages. This view is only
present when the user has chosen some alert words

It adds 3 dot menu to it linking to the Alert word settings.

It also adds the Alerts view to the condensed view.

Fixes part of zulip#28778.

roanster007 added a commit to roanster007/zulip that referenced this issue


          left_sidebar: Add unread counts to the Alert Views.

d2feff2

This commit adds the unread counts to the Alert Views, both in
condensed and non condensed state.

Fixes: zulip#28778.

roanster007 added a commit to roanster007/zulip that referenced this issue


          left_sidebar_nav_area: Refactor handle_narrow_activated filter_name.

628e057

This commit refactors the handle_narrow_activated method of
the left_sidebar_navigation_area to use a switch case instead
of an if-else in the filter_name.

This is a preparatory commit for zulip#28778.

roanster007 added a commit to roanster007/zulip that referenced this issue


          left_sidebar: Add Alerts views.

ae8b02a

This commit adds a new Alerts view to the left sidebar, clicking
on which narrows to "is: alerted" messages. This view is only
present when the user has chosen some alert words

It adds 3 dot menu to it linking to the Alert word settings.

It also adds the Alerts view to the condensed view.

Fixes part of zulip#28778.

roanster007 added a commit to roanster007/zulip that referenced this issue


          left_sidebar: Add unread counts to the Alert Views.

dfa537c

This commit adds the unread counts to the Alert Views, both in
condensed and non condensed state.

Fixes: zulip#28778.

roanster007 added a commit to roanster007/zulip that referenced this issue


          left_sidebar: Add unread counts to the Alert Views.

696c636

This commit adds the unread counts to the Alert Views, both in
condensed and non condensed state.

Fixes: zulip#28778.

roanster007 added a commit to roanster007/zulip that referenced this issue


          left_sidebar_nav_area: Refactor handle_narrow_activated filter_name.

35dd6b2

This commit refactors the handle_narrow_activated method of
the left_sidebar_navigation_area to use a switch case instead
of an if-else in the filter_name.

This is a preparatory commit for zulip#28778.

roanster007 added a commit to roanster007/zulip that referenced this issue


          left_sidebar: Add Alerts views.

5ff3e85

This commit adds a new Alerts view to the left sidebar, clicking
on which narrows to "is: alerted" messages. This view is only
present when the user has chosen some alert words

It adds 3 dot menu to it linking to the Alert word settings.

It also adds the Alerts view to the condensed view.

Fixes part of zulip#28778.

roanster007 added a commit to roanster007/zulip that referenced this issue


          left_sidebar: Add unread counts to the Alert Views.

d071614

This commit adds the unread counts to the Alert Views, both in
condensed and non condensed state.

Fixes: zulip#28778.

roanster007 added a commit to roanster007/zulip that referenced this issue


          left_sidebar_nav_area: Refactor handle_narrow_activated filter_name.

18b5f6c

This commit refactors the handle_narrow_activated method of
the left_sidebar_navigation_area to use a switch case instead
of an if-else in the filter_name.

This is a preparatory commit for zulip#28778.

roanster007 added a commit to roanster007/zulip that referenced this issue


          left_sidebar: Add Alerts views.

be48d38

This commit adds a new Alerts view to the left sidebar, clicking
on which narrows to "is: alerted" messages. This view is only
present when the user has chosen some alert words

It adds 3 dot menu to it linking to the Alert word settings.

It also adds the Alerts view to the condensed view.

Fixes part of zulip#28778.

roanster007 added a commit to roanster007/zulip that referenced this issue


          left_sidebar: Add unread counts to the Alert Views.

d818825

This commit adds the unread counts to the Alert Views, both in
condensed and non condensed state.

Fixes: zulip#28778.

roanster007 added a commit to roanster007/zulip that referenced this issue


          left_sidebar_nav_area: Refactor handle_narrow_activated filter_name.

346d0d3

This commit refactors the handle_narrow_activated method of
the left_sidebar_navigation_area to use a switch case instead
of an if-else in the filter_name.

This is a preparatory commit for zulip#28778.

roanster007 added a commit to roanster007/zulip that referenced this issue


          left_sidebar: Add Alerts views.

c68a12c

This commit adds a new Alerts view to the left sidebar, clicking
on which narrows to "is: alerted" messages. This view is only
present when the user has chosen some alert words

It adds 3 dot menu to it linking to the Alert word settings.

It also adds the Alerts view to the condensed view.

Fixes part of zulip#28778.

roanster007 added a commit to roanster007/zulip that referenced this issue


          left_sidebar: Add unread counts to the Alert Views.

f54089d

This commit adds the unread counts to the Alert Views, both in
condensed and non condensed state.

Fixes: zulip#28778.

Member

zulipbot commented Mar 20, 2024 •

edited

Loading

@roanster007 You have been unassigned from this issue because you have not made any updates for over 14 days. Please feel free to reclaim the issue if you decide to pick up again. Thanks!

zulipbot unassigned roanster007

zulipbot removed the in progress label

alya added this to Zulip release priorities

Collaborator

Aditya8840 commented Oct 30, 2024

@alya, I wanted to check if it’s still available for work. If it is, I would be happy to take it on!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment