-
-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scroll to sent message when bottom of the screen is in view #23298
Comments
Hello @zulip/design members, this issue was labeled with the "UI experiment" label, so you may want to check it out! |
I believe the logic that is requested to change here is
The caller already does a check (search for I think basically the plan would be to skip messing with a
Would likely need the |
@zulipbot claim |
Updates the autoscroll behavior when sending a message. Will now autoscroll to the bottom of the message list if bottom of the view is visible, moving the message selection to the message at the top of the view. Concerns message_list_view.js and message_viewport.js. Fixes zulip#23298
@alya @timabbott I've opened a PR that implements the desired behavior at #23539. :) It pretty much follows Tim's suggested solution. |
@JoeyPriceless You have been unassigned from this issue because you have not made any updates for over 14 days. Please feel free to reclaim the issue if you decide to pick up again. Thanks! |
Updates the autoscroll behavior when sending a message. Will now autoscroll to the bottom of the message list if bottom of the view is visible, moving the message selection to the message at the top of the view. Concerns message_list_view.js and message_viewport.js. Fixes zulip#23298
@zulipbot claim |
@JoeyPriceless You have been unassigned from this issue because you have not made any updates for over 14 days. Please feel free to reclaim the issue if you decide to pick up again. Thanks! |
Updates the autoscroll behavior when sending a message. Will now autoscroll to the bottom of the message list if bottom of the view is visible, moving the message selection to the message at the top of the view. Concerns message_list_view.js and message_viewport.js. Fixes zulip#23298
Updates the autoscroll behavior when sending a message. Will now autoscroll to the bottom of the message list if bottom of the view is visible, moving the message selection to the message at the top of the view. Concerns message_list_view.js and message_viewport.js. Fixes zulip#23298
Updates the autoscroll behavior when sending a message. Will now autoscroll to the bottom of the message list if bottom of the view is visible, moving the message selection to the message at the top of the view. Concerns message_list_view.js and message_viewport.js. Fixes zulip#23298
Updates the autoscroll behavior when sending a message. Will now autoscroll to the bottom of the message list if bottom of the view is visible, moving the message selection to the message at the top of the view. Fixes zulip#23298.
Now whenever the bottom of the feed is visible, we always scroll to the message that was just added, updating the selected message if necessary. Fixes: zulip#23298.
Now whenever the bottom of the feed is visible, we always scroll to the message/s just sent by the current user, updating the selected message if necessary. Scroll behaviour for messages sent by other users remains unchanged. Fixes: zulip#23298.
Now whenever the bottom of the feed is visible, we always scroll to the message/s just sent by the current user, updating the selected message if necessary. Scroll behaviour for messages sent by other users remains unchanged. Fixes: zulip#23298.
Now whenever the bottom of the feed is visible, we always scroll to the message/s just sent by the current user, updating the selected message if necessary. Scroll behaviour for messages sent by other users remains unchanged. Fixes: #23298.
Now whenever the bottom of the feed is visible, we always scroll to the message/s just sent by the current user, updating the selected message if necessary. Scroll behaviour for messages sent by other users remains unchanged. Fixes: #23298.
Now whenever the bottom of the feed is visible, we always scroll to the message/s just sent by the current user, updating the selected message if necessary. Scroll behaviour for messages sent by other users remains unchanged. Fixes: zulip#23298.
Now whenever the bottom of the feed is visible, we always scroll to the message/s just sent by the current user, updating the selected message if necessary. Scroll behaviour for messages sent by other users remains unchanged. Fixes: #23298.
At present, when the user sends a message, and the bottom of the message view is on-screen, we scroll to show the sent message if we can do so without moving the blue selection box. As reported on CZO, this can be confusing to users, as they may not see the message they just sent.
Instead, we should scroll to show the newly sent message any time the bottom of the message view is on-screen. The selection box should just move down to the top message on the screen if needed.
We should leave other checks as they currently are, including active.client_is_active and whether popovers are open.
The text was updated successfully, but these errors were encountered: