Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ntp_make_packet since it is dead code #681

Merged
merged 1 commit into from
Nov 10, 2021
Merged

Remove ntp_make_packet since it is dead code #681

merged 1 commit into from
Nov 10, 2021

Conversation

jonasbb
Copy link
Contributor

@jonasbb jonasbb commented Nov 10, 2021 •
edited
Loading

The function is not called anywhere. The module's make_packet uses udp_make_packet.
The type of ntp_make_packet is also not compatible with probe_make_packet_cb any longer. For example the size_t *buf_len argument is missing.

@jonasbb
Remove ntp_make_packet since it is dead code
50e9ef9 
The function is not called anywhere. The module's make_packet uses `udp_make_packet`.
The type of `ntp_make_packet` is also not compatible with `probe_make_packet_cb` any longer. For example the `size_t *buf_len` argument is missing.
@dadrian
Copy link
Member

dadrian commented Nov 10, 2021

Thanks, I meant to do this when I cleaned up the probe module interface.

@dadrian dadrian merged commit 981a176 into zmap:main Nov 10, 2021
@jonasbb jonasbb deleted the patch-1 branch November 10, 2021 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dadrian dadrian dadrian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonasbb @dadrian