-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add by_name_seek() for Stored zips #69
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/read.rs # src/write.rs
Pr0methean
added
please-sign-your-commit
Please fix failing tests
Tests are failing with this change; please fix them.
labels
May 2, 2024
Signed-off-by: Chris Hennick <4961925+Pr0methean@users.noreply.github.com>
Pr0methean
removed
the
Please fix failing tests
Tests are failing with this change; please fix them.
label
May 3, 2024
Signed-off-by: Chris Hennick <4961925+Pr0methean@users.noreply.github.com>
Pr0methean
added
waiting to be automatically merged
If this PR isn't automatically merged, suspect a broader issue.
Please fix failing tests
Tests are failing with this change; please fix them.
and removed
Please sign your commit
waiting to be automatically merged
If this PR isn't automatically merged, suspect a broader issue.
labels
Jul 6, 2024
Pr0methean
added
waiting to be automatically merged
If this PR isn't automatically merged, suspect a broader issue.
and removed
Please fix failing tests
Tests are failing with this change; please fix them.
labels
Jul 6, 2024
Pr0methean
commented
Jul 15, 2024
Signed-off-by: Chris Hennick <4961925+Pr0methean@users.noreply.github.com>
Pr0methean
removed
the
waiting to be automatically merged
If this PR isn't automatically merged, suspect a broader issue.
label
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces zip-rs/zip-old#369.