Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Improve FixedSizeBlock #212

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

a1phyr
Copy link
Contributor

@a1phyr a1phyr commented Jul 12, 2024

  • Remove allocations
  • Make unsafe code easier to check
  • Prevent potential repr(Rust) fields reordering

- Remove allocations
- Make unsafe code easier to check
- Prevent potential `repr(Rust)` fields reordering
@a1phyr a1phyr force-pushed the improve_unsafe_code branch from b55ca95 to 7a8048b Compare July 12, 2024 09:11
@a1phyr a1phyr requested a review from Pr0methean July 15, 2024 08:35
@Pr0methean Pr0methean added this pull request to the merge queue Jul 15, 2024
@Pr0methean Pr0methean added the waiting to be automatically merged If this PR isn't automatically merged, suspect a broader issue. label Jul 15, 2024
@Pr0methean Pr0methean changed the title Improve FixedSizeBlock refactor: Improve FixedSizeBlock Jul 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jul 15, 2024
@Pr0methean Pr0methean added this pull request to the merge queue Jul 16, 2024
@cosmicexplorer
Copy link
Contributor

@a1phyr This is a great change, thanks so much for improving this!

@Pr0methean Pr0methean removed this pull request from the merge queue due to a manual request Jul 16, 2024
@Pr0methean Pr0methean added this pull request to the merge queue Jul 17, 2024
Merged via the queue into zip-rs:master with commit b8c1457 Jul 17, 2024
38 checks passed
@Pr0methean Pr0methean removed the waiting to be automatically merged If this PR isn't automatically merged, suspect a broader issue. label Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants