Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zio 1.0.0 rc21 #92

Merged
merged 6 commits into from
Jun 30, 2020
Merged

Zio 1.0.0 rc21 #92

merged 6 commits into from
Jun 30, 2020

Conversation

regis-leray
Copy link
Member

No description provided.

mijicd
mijicd previously approved these changes Jun 29, 2020
Copy link
Member

@mijicd mijicd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with two small corrections!

build.sbt Outdated
@@ -27,24 +27,24 @@ inThisBuild(
addCommandAlias("fmt", "all scalafmtSbt scalafmt test:scalafmt")
addCommandAlias("check", "all scalafmtSbtCheck scalafmtCheck test:scalafmtCheck")

val zioVersion = "1.0.0-RC20"
val zioVersion = "1.0.0-RC21"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can bump this one to use 21-1.

build.sbt Outdated
"dev.zio" %% "zio-test-sbt" % zioVersion % Test
"dev.zio" %% "zio" % zioVersion,
"dev.zio" %% "zio-streams" % zioVersion,
"dev.zio" %% "zio-nio" % "1.0.0-RC7",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, RC8 is now available.

@regis-leray
Copy link
Member Author

@mijicd thanks for your review, i applied the changes.
can you please verify my rights on this repo zio-ftp i dont have admin access, i have no issue with zio-s3

@mijicd
Copy link
Member

mijicd commented Jun 30, 2020

@regis-leray Should be fixed now.

@regis-leray regis-leray merged commit 21ef7b8 into master Jun 30, 2020
@regis-leray regis-leray deleted the zio-1.0.0-rc21 branch June 30, 2020 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants