Unsecure FTP downloads fix #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
regis-leray
commented
Jan 8, 2022
regis-leray
commented
- Add a unit test that ensures the finalizer is called and errors are propagated on error channel
- Fix the readFile code so the error is propagated on the error channel
- clean up readFile slightly (an inputstream was created in a ZStream, which was evaluated, and then the inputstream was wrapped in another ZIO; split it up so it does less work)
- Add a unit test that ensures the finalizer is called and errors are propagated on error channel - Fix the readFile code so the error is propagated on the error channel - clean up readFile slightly (an inputstream was created in a ZStream, which was evaluated, and then the inputstream was wrapped in another ZIO; split it up so it does less work)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.