Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[milvus] add Deployment strategy configuration #56

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

Archalbc
Copy link
Contributor

@Archalbc Archalbc commented Feb 6, 2024

What this PR does / why we need it:

Allow to specify the Deployment' strategy for "node" components (indexNode, queryNode, dataNode, proxyNode).
Usefull when you want more control on the RollingUpdate process (maxUnavailable, maxSurge...).

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [mychartname])
  • PR only contains changes for one chart

@Archalbc Archalbc force-pushed the master branch 3 times, most recently from 374913e to e99696b Compare February 6, 2024 17:05
@mergify mergify bot added the ci-passed label Feb 6, 2024
@haorenfsa
Copy link
Collaborator

Hi @Archalb
Thank you for providing this patch! Before we could merge it, please rebase the current master and bump the chart version again.

Signed-off-by: Jeremy Smadja <jeremy.smadja@adevinta.com>
@Archalbc Archalbc reopened this Feb 26, 2024
@mergify mergify bot removed the ci-passed label Feb 26, 2024
@Archalbc
Copy link
Contributor Author

Hi @Archalb Thank you for providing this patch! Before we could merge it, please rebase the current master and bump the chart version again.

Done! Thank you :)

@mergify mergify bot added the ci-passed label Feb 26, 2024
@haorenfsa
Copy link
Collaborator

/lgtm

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: Archalbc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 75bc174 into zilliztech:master Feb 27, 2024
7 checks passed
@haorenfsa haorenfsa mentioned this pull request Feb 27, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants