Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix metaclass conflict error when installing pydantic v2 and using langchain #555

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

SimFG
Copy link
Collaborator

@SimFG SimFG commented Oct 20, 2023

/kind improvement
Fix metaclass conflict error when installing pydantic v2 and using langchain
thanks @yacchi

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SimFG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…ngchain

Signed-off-by: Yasunori Fujie <fujie@ai2-jp.com>
@yacchi
Copy link
Contributor

yacchi commented Oct 20, 2023

  • Changed to not install pydantic in the langchain test because it is installed as a dependency of langchain.
  • Changed to signoff commit.

@SimFG SimFG merged commit 57b1827 into zilliztech:dev Oct 23, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants