Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the langchain chat pydantic bug #538

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Fix the langchain chat pydantic bug #538

merged 1 commit into from
Sep 14, 2023

Conversation

SimFG
Copy link
Collaborator

@SimFG SimFG commented Sep 14, 2023

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SimFG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the dco-passed label Sep 14, 2023
@SimFG SimFG mentioned this pull request Sep 14, 2023
Closed
@SimFG
Fix the langchain chat pydantic bug
18dae36 
Signed-off-by: SimFG <bang.fu@zilliz.com>
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #538 (18dae36) into dev (f9456aa) will decrease coverage by 0.99%.
Report is 2 commits behind head on dev.
The diff coverage is 83.95%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #538      +/-   ##
==========================================
- Coverage   93.90%   92.91%   -0.99%     
==========================================
  Files          96       97       +1     
  Lines        4017     4249     +232     
==========================================
+ Hits         3772     3948     +176     
- Misses        245      301      +56
Files Changed Coverage Δ
gptcache/adapter/adapter.py 82.74% <ø> (-5.31%) ⬇️
gptcache/manager/scalar_data/manager.py 85.18% <33.33%> (-6.49%) ⬇️
gptcache/adapter/openai.py 81.57% <41.66%> (-13.05%) ⬇️
gptcache/manager/scalar_data/dynamo_storage.py 95.16% <95.16%> (ø)
gptcache/adapter/langchain_models.py 95.29% <100.00%> (+0.05%) ⬆️

... and 1 file with indirect coverage changes

@SimFG SimFG merged commit 3339e52 into zilliztech:dev Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cxie cxie Awaiting requested review from cxie

@xiaofan-luan xiaofan-luan Awaiting requested review from xiaofan-luan

Assignees
No one assigned
Labels
approved dco-passed size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SimFG @sre-ci-robot