[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SimFG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

@wybryan
I put the health_check parameter in the cache in the config, which can be set during initialization or separately

cache.init(config=Config(data_check=True))
# or
cache.config.data_check = True

@wybryan I put the health_check parameter in the cache in the config, which can be set during initialization or separately

cache.init(config=Config(data_check=True))
# or
cache.config.data_check = True

quick note, there is a bug in the GPTCache: for Chroma to work, the embeddings must be converted to float64, otherwise you get save failure message from chroma.

@wybryan I put the health_check parameter in the cache in the config, which can be set during initialization or separately

cache.init(config=Config(data_check=True))
# or
cache.config.data_check = True

quick note, there is a bug in the GPTCache: for Chroma to work, the embeddings must be converted to float64, otherwise you get save failure message from chroma.

I have a local fix by subclass SBERT class and implment to_float64_embeddings() method for Chroma, but I am not sure it is the best way to do it, I'll let you decide. :)

I also encountered this problem when I wrote the test, this pr will fix it, because this test writes a test about Chromadb

Codecov Report

Merging #457 (9c6294f) into dev (94c8471) will increase coverage by 0.14%.
The diff coverage is 82.60%.

@@            Coverage Diff             @@
##              dev     #457      +/-   ##
==========================================
+ Coverage   93.88%   94.03%   +0.14%     
==========================================
  Files          91       91              
  Lines        3452     3452              
==========================================
+ Hits         3241     3246       +5     
+ Misses        211      206       -5