Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the BaseCacheLLM abstract class to wrap the llm #394

Merged
merged 1 commit into from
May 29, 2023
Merged

Add the BaseCacheLLM abstract class to wrap the llm #394

merged 1 commit into from
May 29, 2023

Conversation

SimFG
Copy link
Collaborator

@SimFG SimFG commented May 29, 2023

No description provided.

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SimFG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot requested review from cxie and xiaofan-luan May 29, 2023 06:52
@mergify mergify bot added the dco-passed label May 29, 2023
@SimFG SimFG force-pushed the dev branch 2 times, most recently from 68424c8 to 706acd1 Compare May 29, 2023 07:08
@SimFG
Add the BaseCacheLLM abstract class to wrap the llm
10b4500 
Signed-off-by: SimFG <bang.fu@zilliz.com>
@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Merging #394 (10b4500) into dev (0c67584) will increase coverage by 0.03%.
The diff coverage is 98.48%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #394      +/-   ##
==========================================
+ Coverage   94.05%   94.08%   +0.03%     
==========================================
  Files          81       82       +1     
  Lines        2743     2758      +15     
==========================================
+ Hits         2580     2595      +15     
  Misses        163      163
Impacted Files Coverage Δ
gptcache/adapter/api.py 98.14% <ø> (ø)
gptcache/manager/object_data/__init__.py 100.00% <ø> (ø)
gptcache/manager/object_data/manager.py 85.71% <ø> (ø)
gptcache/manager/scalar_data/__init__.py 100.00% <ø> (ø)
gptcache/manager/scalar_data/manager.py 100.00% <ø> (ø)
gptcache/manager/vector_data/__init__.py 100.00% <ø> (ø)
gptcache/manager/vector_data/manager.py 98.57% <ø> (ø)
gptcache/adapter/openai.py 92.54% <96.66%> (+0.18%) ⬆️
gptcache/adapter/base.py 100.00% <100.00%> (ø)
gptcache/adapter/diffusers.py 93.93% <100.00%> (ø)
... and 5 more

@mergify mergify bot added the ci-passed label May 29, 2023
@SimFG SimFG merged commit 873fca7 into zilliztech:dev May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cxie cxie Awaiting requested review from cxie

@xiaofan-luan xiaofan-luan Awaiting requested review from xiaofan-luan

Assignees
No one assigned
Labels
approved ci-passed dco-passed size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SimFG @sre-ci-robot