Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DocArray as a vectorstore #351

Merged
merged 3 commits into from
May 16, 2023
Merged

Conversation

jupyterjazz
Copy link
Contributor

Hey, I'd like to add DocArray's InMemoryExactNNIndex as a vector store

Lmk if I should change/add something

Thanks!

Signed-off-by: jupyterjazz <saba.sturua@jina.ai>
Signed-off-by: jupyterjazz <saba.sturua@jina.ai>
Signed-off-by: jupyterjazz <saba.sturua@jina.ai>
@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Merging #351 (92cc0c4) into dev (dd0f16f) will increase coverage by 0.06%.
The diff coverage is 97.67%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #351      +/-   ##
==========================================
+ Coverage   94.02%   94.08%   +0.06%     
==========================================
  Files          76       77       +1     
  Lines        2542     2585      +43     
==========================================
+ Hits         2390     2432      +42     
- Misses        152      153       +1     
Impacted Files Coverage Δ
gptcache/manager/vector_data/__init__.py 100.00% <ø> (ø)
gptcache/manager/vector_data/chroma.py 87.09% <ø> (ø)
gptcache/manager/vector_data/faiss.py 100.00% <ø> (ø)
gptcache/manager/vector_data/hnswlib_store.py 95.91% <ø> (ø)
gptcache/manager/vector_data/milvus.py 87.17% <ø> (ø)
gptcache/manager/vector_data/pgvector.py 97.56% <ø> (ø)
gptcache/manager/vector_data/docarray_index.py 97.29% <97.29%> (ø)
gptcache/manager/vector_data/manager.py 98.57% <100.00%> (+0.08%) ⬆️
gptcache/utils/__init__.py 89.58% <100.00%> (+0.22%) ⬆️

@mergify mergify bot added the ci-passed label May 16, 2023
Copy link
Collaborator

@SimFG SimFG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jupyterjazz, SimFG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@SimFG
Copy link
Collaborator

SimFG commented May 16, 2023

@jupyterjazz thanks your contribution

@sre-ci-robot sre-ci-robot merged commit 8e11f55 into zilliztech:dev May 16, 2023
vax521 pushed a commit to vax521/GPTCache that referenced this pull request May 17, 2023
* feat: docarray vectorstore

Signed-off-by: jupyterjazz <saba.sturua@jina.ai>

* test: fix issues

Signed-off-by: jupyterjazz <saba.sturua@jina.ai>

* refactor: add pgvector back

Signed-off-by: jupyterjazz <saba.sturua@jina.ai>

---------

Signed-off-by: jupyterjazz <saba.sturua@jina.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants