Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some minor polish on cache init #313

Merged
merged 1 commit into from
Apr 29, 2023
Merged

Conversation

Chiiizzzy
Copy link
Contributor

No description provided.

@Chiiizzzy Chiiizzzy removed the request for review from xiaofan-luan April 28, 2023 07:34
@mergify mergify bot added the dco-passed label Apr 28, 2023
Signed-off-by: Kaiyuan Hu <kaiyuan.hu@zilliz.com>
@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Merging #313 (e07ed80) into dev (f5ba15f) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #313      +/-   ##
==========================================
+ Coverage   93.44%   93.51%   +0.06%     
==========================================
  Files          70       71       +1     
  Lines        2290     2314      +24     
==========================================
+ Hits         2140     2164      +24     
  Misses        150      150              
Impacted Files Coverage Δ
gptcache/adapter/api.py 97.97% <100.00%> (+0.02%) ⬆️

... and 2 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Apr 28, 2023
Copy link
Collaborator

@SimFG SimFG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Chiiizzzy, SimFG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 5132f0d into zilliztech:dev Apr 29, 2023
@Chiiizzzy Chiiizzzy deleted the polish branch May 9, 2023 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants