Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 修复 UI 样式以及增加 shouldShowPageFullScreenButton prop #219

Merged
merged 1 commit into from
Sep 23, 2021
Merged

feat: 修复 UI 样式以及增加 shouldShowPageFullScreenButton prop #219

merged 1 commit into from
Sep 23, 2021

Conversation

fantasy525
Copy link
Contributor

@fantasy525 fantasy525 commented Sep 18, 2021 •
edited
Loading

Pull Request Template

Description

1.修复一些样式问题
2.设置默认隐藏网页全屏
3.修复切换清晰度后倍速还原的问题
4.优化清晰度按钮文案展示

Fixes # (issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • 本地自测

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@fantasy525 fantasy525 force-pushed the master branch 3 times, most recently from baead46 to 262c8c4 Compare September 22, 2021 10:33
ambar
ambar reviewed Sep 22, 2021
View reviewed changes
example/src/IframePage.tsx Outdated Show resolved Hide resolved
@fantasy525 fantasy525 force-pushed the master branch 2 times, most recently from 64db11a to 012de5c Compare September 23, 2021 03:26
@fantasy525 fantasy525 force-pushed the master branch 3 times, most recently from c3264f0 to ad5ff6d Compare September 23, 2021 07:05
@ambar ambar changed the title fix: 修复UI样式以及增加hiddenPageFullScreenButton props feat: 修复 UI 样式以及增加 shouldShowPageFullScreenButton prop Sep 23, 2021
@ambar ambar merged commit 825197b into zhihu:master Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambar ambar ambar left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fantasy525 @ambar