Fix weak vtable warning regarding xml_writer #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh - I missed that this failed CI. I didn't get any notification. It looks like the really old MSVC 2015 doesn't fully support C++11?
|
|
Yeah, pugixml doesn't require C++11. In this case it should be easy to move the empty definition of xml_writer dtor to pugixml.cpp. |
|
Ah thanks. I meant to do that, but I switched out to a different project and forgot about this. Will fix it. |
Using Apple clang (clang-1400.0.29.202) with `-Wweak-vtables` would produce the following warning: 'xml_writer' has no out-of-line virtual method definitions; its vtable will be emitted in every translation unit [-Wweak-vtables]
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Apple clang (clang-1400.0.29.202) with
-Wweak-vtableswould produce the following warning:Using the "defaulted default constructor" prevents this.