Signup component created #96
Conversation
|
Hello until you fix travis test I can't review your project. Travis problem: |
There was a problem hiding this comment.
Hello thanks for adding PR. Here's my concerns:
- Sign up wrong font size. The design has 36px, your 20px. Also text is too low.
- Name, email address, password. Text is bold as well as 14px not 16px.
- Avoid using h1, h3, buttons as a selectors use classes instead.
I suggest looking once again to figma. Click on text look at font-size try to make it look closer to design.
Also I'm aware about navbar issue. I will respond regarding that issue a little later.
There was a problem hiding this comment.
Hello looks much better. Now, all is left to do is.
Improve error message according to design.
So you can improve components/units/Span/Span element. Or create your own error element based on that span, and put it similiar to design. To avoid messing up with other designs don't delete span element from components/units/Span/Span.
|
Hey! I modified the styles on the existing Span element so that it matches the design. Please have a look! |
@all-contributors please add @Ninad99 for code