Add fields of struct array support to dataframe creation functions #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
Looks good to me! Thank you for the PR! I'll merge all the checks pass! |
Codecov Report
@@ Coverage Diff @@
## develop #334 +/- ##
=========================================
Coverage 99.967% 99.967%
=========================================
Files 36 36
Lines 3084 3085 +1
=========================================
+ Hits 3083 3084 +1
Misses 1 1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #333
array-typeto support any Spark SQLDataType, in the same fashion we are already doing instruct-field.create-dataframetests, adding tests for struct fields and struct array fields