Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update projects #57

Merged
merged 12 commits into from
Feb 1, 2023
Merged

Update projects #57

merged 12 commits into from
Feb 1, 2023

Conversation

strickvl
Copy link
Contributor

@strickvl strickvl commented Feb 1, 2023

Updated all projects to more or less latest versions and checked that they worked etc.

@strickvl strickvl added bug Something isn't working documentation Improvements or additions to documentation internal labels Feb 1, 2023
@strickvl strickvl requested review from safoinme and bcdurak February 1, 2023 09:48
@dagshub
Copy link

dagshub bot commented Feb 1, 2023

@@ -1,4 +1,4 @@
feature_engine==1.2.0
statsmodels
zenml==0.20.5
zenml==0.31.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this be updated to 0.32.1 or it would require re-testing everything?

zenml==0.31.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

Copy link
Contributor

@safoinme safoinme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you so much for this.
I left a small comment regarding the zenml versions, tho I think it's ready.

@strickvl
Copy link
Contributor Author

strickvl commented Feb 1, 2023

Awesome! Thank you so much for this. I left a small comment regarding the zenml versions, tho I think it's ready.

Given what happened last time with things breaking with the version upgrades, I wouldn't be comfortable releasing it without testing again with the latest version(s).

@htahir1
Copy link
Contributor

htahir1 commented Feb 1, 2023

Eventually we should just add integration tests

@strickvl strickvl merged commit 80f3df2 into main Feb 1, 2023
@strickvl strickvl deleted the feature/APL-2-update-projects branch February 1, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation internal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants