-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various fixes and improvements #3211
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Describe changes
This is a bundle of bug fixes and improvements that were collected during the load tests I have been performing on the ZenML server.
GET /ap1/v1/load-info
, that can be called to fetch some rudimentary information about the current state of the server: how many threads are currently running and how many database connections are established, used or in overflow, in the following format:catching
urllib3.HTTPError
when verifying the Kubernetes service connector credentials helps report better errors to the client in case of connection errors (e.g. missing or invalid certificates)set
_warn_on_response_updates
to False on theServiceConnectorResponse
removes some pesky and very verbose warnings that show up in the server logs because thetype
field is intentionally overwritten in transit.makes some Helm chart fixes and improvements
zenml.database.poolSize
andzenml.database.maxOverflow
values is currently breaking the deployment, because these values are integer and not processed properly in the Helm chart secret definitionZENML_STORE_*
environment variables instead of setting them individually all over the place, just like we do with server settings and secret store settings.updated all our middlewares to be better behaved and catch all exceptions that the next middleware called with
call_next
might throw and return a response, instead of letting the exception slip. This is a recommendation that came up during load testing, as some of these errors were polluting the logs without revealing the real source of the problem.this PR contains some fixes and improvements for the database backup/restore functionality
created
date takes 50 seconds when that table has around 80k rows. For this reason, we always sort by the index columns (with the exception below)created
timestamp, to avoid breaking the foreign key constraint later on when the database dump is restored. This is now replaced with a different strategy: we detect which tables have self-references and then we simply disable the constraint checks during the database restore operation only for these tables.boost server availability during Kubernetes rolling updates: done simply by making the server pod wait a bit before receiving the SIGTERM signal. This completely elliminates HTTP 503 errors received by clients during rolling updates !!!
make the ZenML client more robust by retrying on various status codes and read errors.
Pre-requisites
Please ensure you have done the following:
develop
and the open PR is targetingdevelop
. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes