Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix in GitLab Code Repository integration #3076

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Bugfix in GitLab Code Repository integration #3076

merged 2 commits into from
Oct 17, 2024

Conversation

4gt-104
Copy link
Contributor

@4gt-104 4gt-104 commented Oct 11, 2024 •
edited
Loading

Describe changes

I fixed check_remote_url method in GitLabCodeRepository class to resolve #3075.
Although I would like to add tests to cover my changes, I was not able to find any tests covering GitLabCodeRepository class.

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.
  • If my changes require changes to the dashboard, these changes are communicated/requested.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@4gt-104
Fix bug in GitLab CR integration
2a45cf0 
Modify `check_remote_url` method adding
support for resolving SSH URLs when
non-default port is used.

Resolves: zenml-io#3075
Signed-off-by: Tigran Grigoryan <grigoryan.tigran119@gmail.com>
@4gt-104 4gt-104 changed the base branch from main to develop October 11, 2024 16:43
@4gt-104
Modify ssh matching regex.
de1f2ee 
Make the regex stricter by enforcing
the use of the appropriate delimiter
when defining a schema.

Signed-off-by: Tigran Grigoryan <grigoryan.tigran119@gmail.com>
@schustmi
Copy link
Contributor

Hey @4gt-104, thanks for the PR!
If you want to add tests (which would be amazing), feel free to create a file in tests/integration/integrations/gitlab for this.

@schustmi schustmi merged commit 5e89a5b into zenml-io:develop Oct 17, 2024
44 of 48 checks passed
@4gt-104 4gt-104 mentioned this pull request Oct 18, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schustmi schustmi schustmi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@4gt-104 @schustmi