Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump mlflow to 2.15.0 #2896

Merged
merged 11 commits into from
Aug 8, 2024
Merged

Bump mlflow to 2.15.0 #2896

merged 11 commits into from
Aug 8, 2024

Conversation

christianversloot
Copy link
Contributor

Describe changes

This PR bumps mlflow to its most recent version, 2.15.0. I ran our test pipeline using zenml==0.63.0 against mlflow==2.15.0 and it succeeded:

image
image

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.
  • If my changes require changes to the dashboard, these changes are communicated/requested.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 31, 2024

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@htahir1 htahir1 requested a review from avishniakov August 6, 2024 12:17
avishniakov
avishniakov approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@avishniakov avishniakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing!

@christianversloot
Copy link
Contributor Author

@avishniakov No worries! Worthwhile to bump this PR to 2.15.1 before merging? https://github.com/mlflow/mlflow/releases/tag/v2.15.1

@htahir1
Copy link
Contributor

htahir1 commented Aug 7, 2024

@christianversloot go for it!

@avishniakov
Copy link
Contributor

@christianversloot , we had a chat internally, what about making "mlflow>=2.1.1,<3", and keeping it like that until something breaks?

@christianversloot
Copy link
Contributor Author

@avishniakov fine with me! Do your tests always work with the latest version? :)

htahir1
htahir1 requested changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@htahir1 htahir1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@christianversloot How bout trying this? We'll merge this if it works now

src/zenml/integrations/mlflow/__init__.py Outdated Show resolved Hide resolved
@avishniakov
Copy link
Contributor

@avishniakov fine with me! Do your tests always work with the latest version? :)

Yes, with the latest installable (a bit of a disclaimer if the latest-latest will not be installable due to the dependencies clash)

@christianversloot
Copy link
Contributor Author

@htahir1 @avishniakov Sure, good idea and nice that it works, I have a rather busy schedule today so will likely be able to adapt second part of the afternoon, if you need it before feel free to push a commit yourself :)

@htahir1 htahir1 merged commit 2a01660 into zenml-io:develop Aug 8, 2024
68 checks passed
@christianversloot christianversloot deleted the feature/mlflow-2.15.0 branch August 8, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avishniakov avishniakov avishniakov approved these changes

@htahir1 htahir1 htahir1 approved these changes

Assignees
No one assigned
Labels
run-slow-ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@christianversloot @htahir1 @avishniakov