Skip to content
This repository has been archived by the owner on Jan 29, 2024. It is now read-only.

Fix index in fetching the last unlisted run #27

Merged
merged 3 commits into from
Mar 9, 2023

Conversation

stefannica
Copy link
Contributor

No description provided.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@stefannica stefannica requested review from htahir1 and schustmi March 4, 2023 10:05
Copy link
Contributor

@htahir1 htahir1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose this only makes sense when we upgrade the requirements.txt to have ZenML 0.35.0

@stefannica
Copy link
Contributor Author

I suppose this only makes sense when we upgrade the requirements.txt to have ZenML 0.35.0

Done, but we always install the latest ZenML in the notebooks anyway, so this wasn't a problem so far.

@stefannica stefannica requested a review from htahir1 March 8, 2023 22:32
Copy link
Contributor

@htahir1 htahir1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! Again, hope its all tested with the latest version? :-)

@stefannica
Copy link
Contributor Author

Makes sense! Again, hope its all tested with the latest version? :-)

Now it is :-)

@stefannica stefannica merged commit 04c613c into main Mar 9, 2023
@stefannica stefannica deleted the bug/fix-last-run-fetch branch March 9, 2023 15:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants