This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Catch LogicException for Rewind and fix CP errors #4154
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rewind method is, as the valid() method, affected by an issue with the GlobIterator where it throws a LogicException if the dataset is empty (https://bugs.php.net/bug.php?id=55701). This exception should be caught and correctly returned as this will interfere with foreach statements at the invoker. In addition to the above have several copy-paste errors in the DocBlocks been fixed.
|
The failed travis build is not due to a failed unit test but some weirdness in the 5.3.3 build |
ghost
assigned 
|
This actually applies against master as well, so I took the liberty of cherry-picking the commit to ensure it makes it into 2.1.5 as well. Thanks, Mike! |
weierophinney
added a commit
to zendframework/zend-cache
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-cache
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rewind method is, as the valid() method, affected by an issue
with the GlobIterator where it throws a LogicException if the dataset
is empty (https://bugs.php.net/bug.php?id=55701).
This exception should be caught and correctly returned as this will
interfere with foreach statements at the invoker.
In addition to the above have several copy-paste errors in the
DocBlocks been fixed.