This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
fixed Exception\InvalidArgumentException messages in Zend\Log #3968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -237,7 +237,8 @@ public function addWriter($writer, $priority = 1, array $options = null) | |||
| $writer = $this->writerPlugin($writer, $options); | |||
| } elseif (!$writer instanceof Writer\WriterInterface) { | |||
| throw new Exception\InvalidArgumentException(sprintf( | |||
| 'Writer must implement Zend\Log\Writer; received "%s"', | |||
| 'Writer must implement %s\Writer\WriterInterface; received "%s"', | |||
There was a problem hiding this comment.
Just curious. Why? Agree with WriterInterface, but by use "NAMESPACE" instead of "Zend\Log" as string?
There was a problem hiding this comment.
I saw that was the common usage of Exception\InvalidArgumentException in other classes
|
Great, good to merge for me. |
ghost
assigned
weierophinney
added a commit
that referenced
this pull request
Mar 12, 2013
fixed Exception\InvalidArgumentException messages in Zend\Log
weierophinney
added a commit
to zendframework/zend-log
that referenced
this pull request
May 15, 2015
…xceptions fixed Exception\InvalidArgumentException messages in Zend\Log
weierophinney
added a commit
to zendframework/zend-log
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-log
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.