This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Add missing @return annotations #3808
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @param string $permission | ||
| * @param \Zend\Permissions\Rbac\AssertionInterface|Callable|null $assert | ||
| * @param string $permission | ||
| * @param \Zend\Permissions\Rbac\AssertionInterface|Callable|null $assert |
There was a problem hiding this comment.
in same folder, it should be only AssertionInterface|Callable|null $assert without \Zend\Permissions\Rbac\ prefix.
There was a problem hiding this comment.
The phpDoc of this method misses the $role parameter as well. But both changes should not be part of this PR, as that's not the topic of this PR.
ghost
assigned 
weierophinney
added a commit
to zendframework/zend-test
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-test
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-stdlib
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-stdlib
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-crypt
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-crypt
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-filter
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-filter
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-permissions-rbac
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-permissions-rbac
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.