This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Fixed a bug where mail messages were malformed when using the Sendmail #3757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
transport on Unix systems with certain versions of sendmail (e.g. Postfix < 2.9). Specifically, message headers spilled into the body and the body text was double-spaced. The source of the problem was the use of CRLF as the EOL sequence when sending messages via PHP's built-in mail() function on Unix systems. Despite what the PHP manual says, LF should be used as the sole EOL character on Unix. This is because mail() is a wrapper for sendmail on Unix and does not speak SMTP except on Windows.
|
Looks like I didn't cast a wide-enough net. The recipients and subject must also be EOL translated. |
being independantly wrapped. Now we convert line-endings on $to, $subject, $body and $headers immediately before calling mail().
ghost
assigned 
weierophinney
added a commit
to zendframework/zend-mail
that referenced
this pull request
May 14, 2015
weierophinney
added a commit
to zendframework/zend-mail
that referenced
this pull request
May 14, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
transport on Unix systems with certain versions of sendmail (e.g.
Postfix < 2.9). Specifically, message headers spilled into the body
and the body text was double-spaced.
The source of the problem was the use of CRLF as the EOL sequence
when sending messages via PHP's built-in mail() function on Unix
systems. Despite what the PHP manual says, LF should be used as the
sole EOL character on Unix. This is because mail() is a wrapper for
sendmail on Unix and does not speak SMTP except on Windows.
See http://zend-framework-community.634137.n4.nabble.com/Zend-Mail-and-Postfix-lt-2-9-td4658920.html for further discussion.