This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Feature/datetime factory format #3437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eit/zf2 into feature/datetime_factory_format
| * - format: A PHP date() compatible string | ||
| * | ||
| * @param array|\Traversable $options | ||
| * @return DateSelect |
Did not want to duplicate the check done in Element, but rather used to already converted $this->options instead
| @@ -52,6 +52,24 @@ class DateTime extends Element implements InputProviderInterface | |||
| protected $validators; | |||
|
|
|||
| /** | |||
| * Accepted options for DateTime: | |||
There was a problem hiding this comment.
Use {@inheritDoc} to inherit parent method documentation too
|
@pdobrigkeit missing tests? |
| * - format: A \DateTime compatible string | ||
| * | ||
| * @param array|\Traversable $options | ||
| * @return DateSelect |
There was a problem hiding this comment.
return type should be DateTime or Zend\Form\Element
|
Added a test. But someone should check the other form elements for |
|
That is tested in ZendTest\Form\ElementTest |
|
Take a look at for example |
Maks3w
added a commit
that referenced
this pull request
Jan 16, 2013
…rmat Feature/datetime factory format
danizord
pushed a commit
to danizord/zf2
that referenced
this pull request
Jan 16, 2013
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the setOptions function to the DateTime form element, which allows to set the accepted format, i.e. when using the array notation to define your elements and the factory.