Fix an issue with inheritance of placeholder registry #3307

lisachenko · 2012-12-29T07:44:18Z

This small patch fixes an issue with logic of Registry getRegistry() method. Method should use static keyword instead of self to allow inheritance.

Issue was detected automatically during the tests with aspect-oriented programming in ZF2 https://github.com/lisachenko/zf2-aspect

…atically with aop inheritance

samsonasik · 2012-12-30T00:16:17Z

@lisachenko : i found 48 new self() in other class

lisachenko · 2012-12-30T05:23:35Z

@samsonasik should I replace all of them to static when LSB is used?

samsonasik · 2012-12-30T07:32:05Z

with php 5.3, i think new static is more usable then new self, . cmiiw

lisachenko · 2012-12-30T15:17:21Z

@samsonasik yes, extending logic of class will be more usable with LSB, especially for Ldap filter, added patch for that.

samsonasik · 2012-12-30T15:40:20Z

nice 👍

lisachenko · 2012-12-30T17:51:10Z

Thanks, it's my first PR to ZF2 ))

P.S. I'm working on AOP for PHP if you could take a look at it, I would be grateful to you ))

Demo source code is here https://github.com/lisachenko/zf2-aspect. Here is a snapshot what my library can do with ZF2 demo application https://twitter.com/lisachenko/status/281124645615329280 (no extensions: runkit, aop, etc, no evals, no __call methods, just pure PHP code).

samsonasik · 2012-12-31T12:13:16Z

You're welcome. Great ! ok, forked :)

Pada Dec 31, 2012, at 0:51, Alexander Lisachenko notifications@github.com menulis:

Thanks, it's my first PR to ZF2 ))

P.S. I'm working on AOP for PHP if you could take a look at it, I would be grateful to you ))

Demo source code is here https://github.com/lisachenko/zf2-aspect. Here is a snapshot what my library can do with ZF2 demo application https://twitter.com/lisachenko/status/281124645615329280 (no extensions: runkit, aop, etc, no evals, no __call methods, just pure PHP code).

—
Reply to this email directly or view it on GitHub.

weierophinney · 2013-01-03T21:24:54Z

library/Zend/Code/Generator/PropertyGenerator.php

@@ -39,7 +39,7 @@ class PropertyGenerator extends AbstractMemberGenerator
     */
    public static function fromReflection(PropertyReflection $reflectionProperty)
    {
-        $property = new self();
+        $property = new static();


It appears this one may cause an issue -- travis reports a failing test for the PropertyGenerator here.

weierophinney · 2013-01-03T21:34:33Z

Actually, I'm having trouble tracking down the issue. Essentially, ZendTest\Code\Generator\PropertyGeneratorTest::testPropertyMultilineValue is failing, and it appears that in addition to adding a "," after each element of an array, it's also adding a ";" before the comma. As this does not happen on master, I have to assume the issue is due to adding LSB; the question is: where.

@lisachenko Can you track it down?

lisachenko · 2013-01-04T15:36:32Z

@weierophinney yeah, looks strange...LSB shouldn't break anything. I'll look into the issue

lisachenko · 2013-01-04T16:46:03Z

LSB is the issue ) Class PropertyValueGenerator extends ValueGenerator class and overrides generate() method. So new static() in the ValueGenerator class can not be used because it will create child instead of self.

I'll amend my last commit to be compatible with current logic, however it's better to fix this issue later. Is amending commit is ok for PR?

Forward port #3307 Conflicts: library/Zend/Code/Generator/DocBlock/Tag/LicenseTag.php library/Zend/Code/Generator/DocBlock/Tag/ParamTag.php library/Zend/Code/Generator/DocBlock/Tag/ReturnTag.php

weierophinney · 2013-01-04T17:23:11Z

Excellent - thanks!

Close zendframework/zendframework#3307