This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Added ValidatorChain::attach() and ValidatorChain::attachByName() to keep consistent with FilterChain #3200
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…keep consistent with FilterChain ValidatorChain::addValidator() proxies to ValidatorChain::attach() ValidatorChain::addByName() proxies to ValidatorChain::attachByName()
@@ -107,6 +107,18 @@ public function addValidator(ValidatorInterface $validator, $breakChainOnFailure | |||
} | |||
|
|||
/** | |||
* Proxy to attach() to keep BC | |||
* | |||
* @param ValidatorInterface $validator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should add an @deprecated annotation, pointing to the new method.
ghost
assigned weierophinney
Dec 11, 2012
weierophinney
added a commit
that referenced
this pull request
Dec 11, 2012
weierophinney
added a commit
that referenced
this pull request
Dec 11, 2012
- s/addValidator/attach/ - s/addByName/attachByName/
weierophinney
added a commit
to zendframework/zend-mail
that referenced
this pull request
May 14, 2015
…ator chain methods - s/addValidator/attach/ - s/addByName/attachByName/
weierophinney
added a commit
to zendframework/zend-mail
that referenced
this pull request
May 14, 2015
weierophinney
added a commit
to zendframework/zend-inputfilter
that referenced
this pull request
May 15, 2015
…ator chain methods - s/addValidator/attach/ - s/addByName/attachByName/
weierophinney
added a commit
to zendframework/zend-inputfilter
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-validator
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-validator
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-log
that referenced
this pull request
May 15, 2015
…ator chain methods - s/addValidator/attach/ - s/addByName/attachByName/
weierophinney
added a commit
to zendframework/zend-log
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ValidatorChain::attach() and ValidatorChain::attachByName() to keep consistent with FilterChain
ValidatorChain::addValidator() proxies to ValidatorChain::attach()
ValidatorChain::addByName() proxies to ValidatorChain::attachByName()