This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Hotfix/console 404 reporting #2437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
| $result = $banner ? rtrim($banner, "\r\n") : ''; | ||
| $result .= $usage ? "\n\n" . trim($usage, "\r\n") : ''; | ||
| $result .= "\n"; // to ensure we output a final newline | ||
|
|
||
| // Report 404 reason and/or exceptions |
There was a problem hiding this comment.
This method hereby becomes 100+ lines long. Can't we move this to its own method?
There was a problem hiding this comment.
+1
The getConsoleUsage() method has 100+ lines too 😔
There was a problem hiding this comment.
@Freeaqingme Done.
@b-durand I didn't add any code to getConsoleUsage(), which makes that out-of-scope for this PR.
- If display_not_found_reason is enabled, use this value to display: - reason for "404" - any related exceptions
- so that we can determine full root cause from CLI
- extracted display_not_found_reason and exception reporting to reportNotFoundReason() method, per feedback on pull request.
|
I figured a force push would tell travis to re-run. Odd. Rebased off of latest master, which corrects the CS issues reported in the former travis results. I've also extracted the logic for displaying the exception stack trace to a new method, addressing the concerns @Freeaqingme raised. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds error reporting capabilities to the Console RouteNotFoundStrategy.
If the view_manager "display_not_found_reason" flag is enabled, this will display the reason for the "404" condition, as well as any exceptions, if any, present in the event (looping through all previous exceptions).