This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Proposed fix for ZF2-569 validating float with trailing 0's (10.0, 10.10) #2388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added code for correctly validate ending zeros inside decimal part.
Added test for ending zeros in decimal part.
|
Very nice. I was playing around with the idea to do a But that gave trouble when the value was actually 0 and now it seems I don't have to think anymore ;) |
weierophinney
added a commit
that referenced
this pull request
Sep 19, 2012
- trailing whitespace - break conditional into multiple lines for readability - whitespace around operators
weierophinney
added a commit
that referenced
this pull request
Sep 19, 2012
Forward port #2388 Conflicts: library/Zend/I18n/Validator/Float.php tests/ZendTest/I18n/Validator/FloatTest.php
ghost
assigned
weierophinney
added a commit
to zendframework/zend-i18n
that referenced
this pull request
May 15, 2015
- trailing whitespace - break conditional into multiple lines for readability - whitespace around operators
weierophinney
added a commit
to zendframework/zend-i18n
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-i18n
that referenced
this pull request
May 15, 2015
Forward port zendframework/zendframework#2388 Conflicts: library/Zend/I18n/Validator/Float.php tests/ZendTest/I18n/Validator/FloatTest.php
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actual validation fails with trailing zeros inside decimal part like 10.0 or 10.10. This happens because NumberFormatter->parse('10.0') returns 10 and not 10.0 and the valueFiltered remains '10.0'.
This proposed fix removes all trailing 0 (and ending . if any) from valueFiltered before comparison.
The problem is described in http://framework.zend.com/issues/browse/ZF2-569