Mail\Message::getSubject() should return value the way it was set #2334

Xerkus · 2012-09-10T20:36:39Z

Message return subject in encoded form which is quite unexpected behaviour for end user

$message->setSubject('Subject');
$message->setEncoding('UTF-8');
$message->getSubject(); // Subject
//before this PR:
$message->getSubject(); // =?UTF-8?Q?Subject?=

Transport should retrieve encoded Subject header value from headers and not directly from message object.

weierophinney · 2012-09-13T18:48:26Z

library/Zend/Mail/Transport/Sendmail.php

+            return null;
+        }
+        $header = $headers->get('subject');
+        return $header->getFieldValue(HeaderInterface::FORMAT_ENCODED);


Should this also be done for SMTP and/or File transports? or is it an issue only for the Sendmail transport?

Message::getSubject() was used only in sendmail.
I will check if getters for other properties proxied to Headers are used in transports and replace them with direct access too.

weierophinney · 2012-09-13T21:15:12Z

Merged to master and release branches.

Xerkus added 2 commits September 11, 2012 07:11

message::getSubject return non-encoded value

ecaca97

add test for Mail\Message::getSubject()

45b4a39

weierophinney reviewed Sep 13, 2012
View reviewed changes

ghost assigned weierophinney Sep 13, 2012

weierophinney merged commit 45b4a39 into zendframework:master Sep 13, 2012

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mail\Message::getSubject() should return value the way it was set #2334

Mail\Message::getSubject() should return value the way it was set #2334

Xerkus commented Sep 10, 2012

weierophinney Sep 13, 2012

Xerkus Sep 13, 2012

weierophinney commented Sep 13, 2012

Mail\Message::getSubject() should return value the way it was set #2334

Mail\Message::getSubject() should return value the way it was set #2334

Conversation

Xerkus commented Sep 10, 2012

weierophinney Sep 13, 2012

Choose a reason for hiding this comment

Xerkus Sep 13, 2012

Choose a reason for hiding this comment

weierophinney commented Sep 13, 2012