This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Validator Translations #2312
Merged
Validator Translations #2312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -32,7 +32,7 @@ class Identical extends AbstractValidator | |||
| */ | |||
| protected $messageTemplates = array( | |||
| self::NOT_SAME => "The two given tokens do not match", | |||
| self::MISSING_TOKEN => 'No token was provided to match against', | |||
| self::MISSING_TOKEN => "No token was provided to match against", | |||
There was a problem hiding this comment.
Our coding standards suggest to use single quotes where possible Can you revert this changes?
There was a problem hiding this comment.
My changes in the validators are reverted
|
Hi krmarien, Based on your updated English validation messages, I've also updated the French one. Please could you add it to your PR (and update the description) ? Thanks :) |
|
Merged to release and master branches. |
ghost
assigned
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the English and Dutch validation message translations (http://framework.zend.com/issues/browse/ZF2-491)
French validation messages are also updated (@bakura10)