This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Get rid of error suppression #2210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Thanks to intiilapa (Benoit Durand) - grep -r "@" library/Zend/ | grep -v "*" | grep -v "// @" used to identify suppressions - Used ErrorHandler to remove suppressions
|
The static review looks good for me. However I'll let this open for review for someone more |
|
There are some components affected that doesn't depend on Zend\Stdlib before. |
|
|
|
I found 2 places of |
|
@marc-mabe One of the places using error_get_last() requires its use due to a php limitation (I discovered that during testing yesterday) ; I'll look for the other locations however. |
|
ErrorHandler is simpler to implement and more consistent with usage across the framework; additionally, this is really simply completing an effort I thought I'd already accomplished a couple months ago. (It doesn't help that some new code crept in using error suppression, either.) |
|
@marc-mabe re: ErrorHandler::stop() + ErrorException -- I'll see if there are places that would be useful and update. Thanks. |
- Removed two cases where error_get_last() was being used in Cache component; instead, captures the return from ErrorHandler::stop() and calls its getMessage() method.
|
@Maks3w I think all of the questions @marc-mabe raised are answered at this point. |
| ErrorHandler::start(E_WARNING); | ||
| $fileHandle = fopen($this->filename, 'r'); | ||
| ErrorHandler::stop(); | ||
| if (false === $fileHandle) { | ||
| throw new Exception\UnexpectedValueException("Cannot open '$this->filename' for reading"); |
There was a problem hiding this comment.
//...
$error = ErrorHandler::stop();
if (false === $fileHandle) {
throw new Exception\UnexpectedValueException("Cannot open '$this->filename' for reading", 0, $error); // previous error
//...
weierophinney
added a commit
to zendframework/zend-authentication
that referenced
this pull request
May 14, 2015
…s previous exception - Per @mark-mabe - Any place where an exception is throw immediately following an ErrorHandler::stop() call should pass the result of that call as the previous exception.
weierophinney
pushed a commit
to zendframework/zend-authentication
that referenced
this pull request
May 14, 2015
…y/hotfix/remove-suppression-operator Get rid of error suppression
weierophinney
added a commit
to zendframework/zend-mail
that referenced
this pull request
May 14, 2015
…s previous exception - Per @mark-mabe - Any place where an exception is throw immediately following an ErrorHandler::stop() call should pass the result of that call as the previous exception.
weierophinney
pushed a commit
to zendframework/zend-mail
that referenced
this pull request
May 14, 2015
…y/hotfix/remove-suppression-operator Get rid of error suppression
gianarb
pushed a commit
to zendframework/zend-serializer
that referenced
this pull request
May 15, 2015
…y/hotfix/remove-suppression-operator Get rid of error suppression
weierophinney
added a commit
to zendframework/zend-i18n
that referenced
this pull request
May 15, 2015
…s previous exception - Per @mark-mabe - Any place where an exception is throw immediately following an ErrorHandler::stop() call should pass the result of that call as the previous exception.
gianarb
pushed a commit
to zendframework/zend-i18n
that referenced
this pull request
May 15, 2015
…y/hotfix/remove-suppression-operator Get rid of error suppression
weierophinney
added a commit
to zendframework/zend-text
that referenced
this pull request
May 15, 2015
…s previous exception - Per @mark-mabe - Any place where an exception is throw immediately following an ErrorHandler::stop() call should pass the result of that call as the previous exception.
gianarb
pushed a commit
to zendframework/zend-text
that referenced
this pull request
May 15, 2015
…y/hotfix/remove-suppression-operator Get rid of error suppression
gianarb
pushed a commit
to zendframework/zend-xmlrpc
that referenced
this pull request
May 15, 2015
…y/hotfix/remove-suppression-operator Get rid of error suppression
weierophinney
added a commit
to zendframework/zend-http
that referenced
this pull request
May 15, 2015
…s previous exception - Per @mark-mabe - Any place where an exception is throw immediately following an ErrorHandler::stop() call should pass the result of that call as the previous exception.
gianarb
pushed a commit
to zendframework/zend-http
that referenced
this pull request
May 15, 2015
…y/hotfix/remove-suppression-operator Get rid of error suppression
gianarb
pushed a commit
to zendframework/zend-server
that referenced
this pull request
May 15, 2015
…y/hotfix/remove-suppression-operator Get rid of error suppression
weierophinney
added a commit
to zendframework/zend-progressbar
that referenced
this pull request
May 15, 2015
…s previous exception - Per @mark-mabe - Any place where an exception is throw immediately following an ErrorHandler::stop() call should pass the result of that call as the previous exception.
gianarb
pushed a commit
to zendframework/zend-progressbar
that referenced
this pull request
May 15, 2015
…y/hotfix/remove-suppression-operator Get rid of error suppression
gianarb
pushed a commit
to zendframework/zend-filter
that referenced
this pull request
May 15, 2015
…y/hotfix/remove-suppression-operator Get rid of error suppression
gianarb
pushed a commit
to zendframework/zend-ldap
that referenced
this pull request
May 15, 2015
…y/hotfix/remove-suppression-operator Get rid of error suppression
gianarb
pushed a commit
to zendframework/zend-json
that referenced
this pull request
May 15, 2015
…y/hotfix/remove-suppression-operator Get rid of error suppression
weierophinney
added a commit
to zendframework/zend-validator
that referenced
this pull request
May 15, 2015
…s previous exception - Per @mark-mabe - Any place where an exception is throw immediately following an ErrorHandler::stop() call should pass the result of that call as the previous exception.
gianarb
pushed a commit
to zendframework/zend-validator
that referenced
this pull request
May 15, 2015
…y/hotfix/remove-suppression-operator Get rid of error suppression
gianarb
pushed a commit
to zendframework/zend-file
that referenced
this pull request
May 15, 2015
…y/hotfix/remove-suppression-operator Get rid of error suppression
weierophinney
added a commit
to zendframework/zend-log
that referenced
this pull request
May 15, 2015
…s previous exception - Per @mark-mabe - Any place where an exception is throw immediately following an ErrorHandler::stop() call should pass the result of that call as the previous exception.
gianarb
pushed a commit
to zendframework/zend-log
that referenced
this pull request
May 15, 2015
…y/hotfix/remove-suppression-operator Get rid of error suppression
weierophinney
added a commit
to zendframework/zend-cache
that referenced
this pull request
May 15, 2015
- Removed two cases where error_get_last() was being used in Cache component; instead, captures the return from ErrorHandler::stop() and calls its getMessage() method.
weierophinney
added a commit
to zendframework/zend-cache
that referenced
this pull request
May 15, 2015
…s previous exception - Per @mark-mabe - Any place where an exception is throw immediately following an ErrorHandler::stop() call should pass the result of that call as the previous exception.
gianarb
pushed a commit
to zendframework/zend-cache
that referenced
this pull request
May 15, 2015
…y/hotfix/remove-suppression-operator Get rid of error suppression
weierophinney
added a commit
to zendframework/zend-view
that referenced
this pull request
May 15, 2015
…s previous exception - Per @mark-mabe - Any place where an exception is throw immediately following an ErrorHandler::stop() call should pass the result of that call as the previous exception.
gianarb
pushed a commit
to zendframework/zend-view
that referenced
this pull request
May 15, 2015
…y/hotfix/remove-suppression-operator Get rid of error suppression
weierophinney
added a commit
to zendframework/zend-navigation
that referenced
this pull request
May 15, 2015
…s previous exception - Per @mark-mabe - Any place where an exception is throw immediately following an ErrorHandler::stop() call should pass the result of that call as the previous exception.
gianarb
pushed a commit
to zendframework/zend-navigation
that referenced
this pull request
May 15, 2015
…y/hotfix/remove-suppression-operator Get rid of error suppression
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
identify suppressions