This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Fieldset #2184
Merged
Fieldset #2184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the motivation for these changes? What does it enable and/or fix? I ask because it introduces changes to interfaces, which we're trying to minimize during the release candidate phase. |
|
Have you read the comment I wrote on the other PR? |
weierophinney
added a commit
that referenced
this pull request
Aug 16, 2012
- Minor whitespace issues
weierophinney
added a commit
that referenced
this pull request
Aug 16, 2012
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed dependency from Fieldset to Collection.
see #2131 (comment)