Raise an exception when timestamp is malformed #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when a provided timestamp didn't match the regex format, it would be configured as `nil`. This was nonsensical since a `nil` timestamp is unusable, which allowed for subtle bugs to creep in. Instead, we should alert the user as soon as an improper timestamp is encountered by raising an informative exception. The documentation has also been updated to reflect the expectations for tiemstamp format. Fixes #140.
craig-day
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when a provided timestamp didn't match the regex format, it would be configured as
nil. This was nonsensical since aniltimestamp is unusable, which allowed for subtle bugs to creep in.Instead, we should alert the user as soon as an improper timestamp is encountered by raising an informative exception.
The documentation has also been updated to reflect the expectations for tiemstamp format.
Fixes #140.
/cc @oelmekki