Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use setLayerType for animations #263

Merged
merged 1 commit into from
Oct 23, 2015
Merged

Conversation

ulyssesdotcodes
Copy link
Contributor

This helps animations run smoothly since there's a lot going on.

The internal mechanics of setLayerType means that this renders each button using the GPU and then animates the rendered version of the view. The buttons don't need to be laid out during the animation, so this works well.

@ulyssesdotcodes
Copy link
Contributor Author

@chalup
Copy link
Contributor

chalup commented Oct 22, 2015

Very nice. I checked the results with "Profile GPU rendering" -> "as bars" in developers options, and the animations definitely put less stress no the device.

This helps animations run smoothly when there's a lot going on.
@ulyssesdotcodes
Copy link
Contributor Author

@chalup Yup! Updated to remove the unused import.

chalup added a commit that referenced this pull request Oct 23, 2015
Use setLayerType for animations
@chalup chalup merged commit c9b265f into zendesk:master Oct 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants