Feat: update composer.json file to match laravel 8 requirements #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivier-zenchef
requested review from
louisgab,
adrien-delhom and
jacem-at-zenchef
jacem-at-zenchef
approved these changes
Aug 25, 2023
adrien-delhom
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://app.clickup.com/t/1596/SUDS-703
In order to upgrade to laravel 9, we need to solve a composer issue first.
It's not the case in laravel 8, but we can still solve it before upgrade.
Laravel 9 replaces Illuminate/support
So
composer updatedoesn't complete with both this fork and laravel itselfWhile a bit overkill, the solution is to require laravel/framework itself:
Currently, we can test the build on API on branch feat/replace-lab123-aws-sns
The composer.json was modified to point to this branch
This PR on api will need to pass after this one