Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deny all Clippy warnings #8720

Merged
merged 11 commits into from
Mar 2, 2024
Merged

Deny all Clippy warnings #8720

merged 11 commits into from
Mar 2, 2024

Conversation

maxdeviant
Copy link
Member

@maxdeviant maxdeviant commented Mar 2, 2024

This PR makes Clippy deny all warnings across the workspace.

We now enumerate all of the rules that have violations and temporarily allow them, with the goal being to drive the list down over time.

On Windows we don't yet use --deny warnings, as the Windows build still has some warnings.

Release Notes:

  • N/A

@maxdeviant maxdeviant self-assigned this Mar 2, 2024
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Mar 2, 2024
@maxdeviant maxdeviant marked this pull request as draft March 2, 2024 17:41
@maxdeviant maxdeviant marked this pull request as ready for review March 2, 2024 20:50
@maxdeviant maxdeviant merged commit bf666af into main Mar 2, 2024
9 checks passed
@maxdeviant maxdeviant deleted the marshall/clippy-deny-warnings branch March 2, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant