-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial support for defining language server adapters in WebAssembly-based extensions #8645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Marshall <marshall@zed.dev>
Co-authored-by: Marshall <marshall@zed.dev>
Co-authored-by: Marshall <marshall@zed.dev>
Also, show that we can pass worktree snapshots into extensions via resources.
Co-authored-by: Marshall <marshall@zed.dev>
Co-authored-by: Marshall <marshall@zed.dev>
Co-authored-by: Marshall <marshall@zed.dev>
Co-authored-by: Marshall <marshall@zed.dev>
Co-authored-by: Marshall <marshall@zed.dev>
… server * Add a method to the Fs trait for extracting tar archives Co-authored-by: Marshall <marshall@zed.dev>
Co-authored-by: Nathan <nathan@zed.dev>
…dLspAdapter Co-authored-by: Marshall <marshall@zed.dev>
Co-authored-by: Marshall <marshall@zed.dev>
Co-authored-by: Marshall <marshall@zed.dev>
Co-authored-by: Marshall <marshall@zed.dev>
Soon, the language won't own LSP adapters. Co-authored-by: Marshall <marshall@zed.dev>
Update zillions of tests to set up fake LSPs differently. Co-authored-by: Marshall <marshall@zed.dev>
cla-bot
bot
added
the
cla-signed
The user has signed the Contributor License Agreement
label
Mar 1, 2024
maxdeviant
reviewed
Mar 1, 2024
maxbrunsfeld
force-pushed
the
wasm-extensions
branch
from
March 1, 2024 03:05
209087f
to
a9ec84a
Compare
20 tasks
Co-authored-by: Marshall <marshall@zed.dev>
* Make it possible to use real lsp adapters in tests, and still observe the stream of fake language servers that are started. Co-authored-by: Marshall <marshall@zed.dev>
Co-authored-by: Marshall <marshall@zed.dev>
…n tests Co-authored-by: Marshall <marshall@zed.dev>
Co-authored-by: Marshall <marshall@zed.dev>
Co-authored-by: Marshall <marshall@zed.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds internal ability to run arbitrary language servers via WebAssembly extensions. The functionality isn't exposed yet - we're just landing this in this early state because there have been a lot of changes to the
LspAdapter
trait, and other language server logic.Next steps
zed-extension-api
has not yet been published to crates.io, because we still consider the API a work in progress.Release Notes: