Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup dependencies (part 4) #8468

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Cleanup dependencies (part 4) #8468

merged 2 commits into from
Feb 27, 2024

Conversation

kvark
Copy link
Contributor

@kvark kvark commented Feb 27, 2024

Follow-up to #8425 . Final part - adds the CI check.

Release Notes:

  • N/A

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Feb 27, 2024
@kvark kvark mentioned this pull request Feb 27, 2024
Open
SomeoneToIgnore
SomeoneToIgnore approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@SomeoneToIgnore SomeoneToIgnore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for pushing it towards a self-sustainable state, no more extra dependencies for us and, hopefully, not that many false-positives in the future PR checks.

.github/workflows/ci.yml Show resolved Hide resolved
@SomeoneToIgnore SomeoneToIgnore merged commit cb75c57 into zed-industries:main Feb 27, 2024
7 checks passed
@kvark kvark deleted the cleanup branch February 29, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxdeviant maxdeviant maxdeviant left review comments

@SomeoneToIgnore SomeoneToIgnore SomeoneToIgnore approved these changes

Assignees
No one assigned
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kvark @maxdeviant @SomeoneToIgnore