-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ZIP 234] NSM: Smooth Issuance Curve #914
Conversation
1. We want to introduce an automated mechanism that allows users of the network | ||
to contribute to the long-term sustainability of the network. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This objective mixes several concerns. ZIP 233 + ZIP 234 (without ZIP 235) provide only a "manual" mechanism for such contributions, by setting the burnAmount
field. Only ZIP 235 makes it "automated".
being introduced to the market. Such sudden shifts can potentially disrupt the | ||
network's economic model, potentially impacting its security and stability. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there concrete evidence that halvings significantly disrupt the network's economic model or have a significant chance of disrupting its security and stability?
There is a possible argument that since changes in miner subsidy are more gradual, potential economic and consensus security problems with those reductions might be seen earlier. However this is only asserted, not convincingly argued.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we agree that since changes in miner subsidy are more gradual, potential economic and consensus security problems with those reductions might be seen earlier.
a034dd4
to
13648d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed with @arya2, @str4d, @daira.
The assumption that this will activate at a halving is incorrect; for semantic stability this ZIP should be modified to eliminate this assumption.
In addition, since NU7 will likely activate before the crossover point (slightly less than 2 years after the halving), if this ZIP takes effect at NU7 activation, it will result in increase in issuance at that time relative to the immediately preceding block subsidies, unless the change in issuance is deferred to the crossover point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I've suggested two edits on behalf of Shielded Labs because it is late late night for @giddie and we wanted to achieve semantic stability in time for the deadline.
Please let me know if these suggested edits would meet the semantic stability threshold, and @giddie and I will keep an eye on this PR over the next day (to cover more hours).
c3363fd
to
7b3d7b5
Compare
Co-authored-by: shielded-nate <shieldednate@proton.me>
7b3d7b5
to
b0d3760
Compare
TODO daira: add a requirement that makes the initial total issuance match the previous total issuance | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO daira: add a requirement that makes the initial total issuance match the previous total issuance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK b0d3760
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK on merge to the draft.
No description provided.