Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZIP 234] NSM: Smooth Issuance Curve #914

Merged
merged 3 commits into from
Nov 6, 2024

Conversation

giddie
Copy link
Contributor

@giddie giddie commented Oct 10, 2024

No description provided.

Comment on lines +53 to +54
1. We want to introduce an automated mechanism that allows users of the network
to contribute to the long-term sustainability of the network.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This objective mixes several concerns. ZIP 233 + ZIP 234 (without ZIP 235) provide only a "manual" mechanism for such contributions, by setting the burnAmount field. Only ZIP 235 makes it "automated".

Comment on lines 65 to 68
being introduced to the market. Such sudden shifts can potentially disrupt the
network's economic model, potentially impacting its security and stability.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there concrete evidence that halvings significantly disrupt the network's economic model or have a significant chance of disrupting its security and stability?

There is a possible argument that since changes in miner subsidy are more gradual, potential economic and consensus security problems with those reductions might be seen earlier. However this is only asserted, not convincingly argued.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we agree that since changes in miner subsidy are more gradual, potential economic and consensus security problems with those reductions might be seen earlier.

@giddie giddie force-pushed the zip-234-nsm-issuance branch 2 times, most recently from a034dd4 to 13648d6 Compare October 25, 2024 13:33
@nuttycom nuttycom added the consensus Consensus changes, and errors or omissions in consensus specification label Nov 4, 2024
zips/zip-0234.md Outdated Show resolved Hide resolved
zips/zip-0234.md Outdated Show resolved Hide resolved
zips/zip-0234.md Outdated Show resolved Hide resolved
Copy link
Contributor

@nuttycom nuttycom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed with @arya2, @str4d, @daira.

The assumption that this will activate at a halving is incorrect; for semantic stability this ZIP should be modified to eliminate this assumption.

In addition, since NU7 will likely activate before the crossover point (slightly less than 2 years after the halving), if this ZIP takes effect at NU7 activation, it will result in increase in issuance at that time relative to the immediately preceding block subsidies, unless the change in issuance is deferred to the crossover point.

Copy link
Contributor

@shielded-nate shielded-nate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I've suggested two edits on behalf of Shielded Labs because it is late late night for @giddie and we wanted to achieve semantic stability in time for the deadline.

Please let me know if these suggested edits would meet the semantic stability threshold, and @giddie and I will keep an eye on this PR over the next day (to cover more hours).

zips/zip-0234.md Show resolved Hide resolved
zips/zip-0234.md Outdated Show resolved Hide resolved
@nuttycom nuttycom force-pushed the zip-234-nsm-issuance branch from c3363fd to 7b3d7b5 Compare November 5, 2024 23:13
@nuttycom nuttycom changed the base branch from main to nu7-stability November 5, 2024 23:26
Co-authored-by: shielded-nate <shieldednate@proton.me>
@nuttycom nuttycom force-pushed the zip-234-nsm-issuance branch from 7b3d7b5 to b0d3760 Compare November 5, 2024 23:31
@nuttycom nuttycom changed the base branch from nu7-stability to main November 5, 2024 23:34
Comment on lines +95 to 96
TODO daira: add a requirement that makes the initial total issuance match the previous total issuance

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
TODO daira: add a requirement that makes the initial total issuance match the previous total issuance

Copy link
Contributor

@nuttycom nuttycom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK b0d3760

Copy link
Collaborator

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Copy link
Collaborator

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK on merge to the draft.

@nuttycom nuttycom merged commit 34c2194 into zcash:main Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consensus Consensus changes, and errors or omissions in consensus specification NU7 proposal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants