[Host.Kafka] Fix and improve commit logic #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zarusz
force-pushed
the
feature/kafka_fix_131
branch
13 times, most recently
from
520b2f1 to
8bf1a5c
Compare
[Host.Kafka] Upgrade to latest Confluent.Kafka.Net library. [Host.Kafka] Extend the kafka docs. [Host.Kafka] Use test containers for Kafka int tests. Signed-off-by: Tomasz Maruszak <maruszaktomasz@gmail.com>
zarusz
force-pushed
the
feature/kafka_fix_131
branch
from
8bf1a5c to
9e4e400
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue raised in #131. Doing further investigation I have found:
EnablePartitionEofset totrue, when the partition ended, SMB was committing too advanced a partition index.CheckpointAfter(TimeSpan)might not happen after the desired time when there are no protocol events that happen (partition assignment or partition EOF).Moreover, the Confluent.Kafka library has being upgraded from 2.3.0 to 2.5.2.