Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Host.FluentValidation] Duplicated error messages #192

Closed
Eniak opened this issue Aug 28, 2023 · 0 comments · Fixed by #193
Closed

[Host.FluentValidation] Duplicated error messages #192

Eniak opened this issue Aug 28, 2023 · 0 comments · Fixed by #193
Assignees
@zarusz
Labels
bug

Comments

@Eniak
Copy link

Eniak commented Aug 28, 2023

I found an issue with AbstractValdiationInterceptor

var validationTasks = _validators
	.Select(x => x.ValidateAsync(context, cancellationToken));

await Task.WhenAll(validationTasks);

var failures = validationTasks
	.SelectMany(x => x.Result.Errors);

if (failures.Any())

I think lack to ToList() or ToArray() causes this collection to be enumerated more than once in scope of this method. Adding these or changing it to

var results = await Task.WhenAll(validationTasks);

var failures = results
    .SelectMany(x => x.Errors);

may fix the problem.
zarusz added a commit that referenced this issue Aug 28, 2023
@zarusz
[Host.FluentValidation] Duplicated error messages #192
af5b9f9 
Signed-off-by: Tomasz Maruszak <maruszaktomasz@gmail.com>
@zarusz zarusz self-assigned this Aug 28, 2023
@zarusz zarusz added the bug label Aug 28, 2023
@zarusz zarusz mentioned this issue Aug 28, 2023
Merged
zarusz added a commit that referenced this issue Aug 28, 2023
@zarusz
[Host.FluentValidation] Duplicated error messages #192
edf66f2 
Signed-off-by: Tomasz Maruszak <maruszaktomasz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zarusz zarusz

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Host.FluentValidation] Duplicated error messages #192 zarusz/SlimMessageBus
2 participants
@Eniak @zarusz