Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip vlen bytes encode none test #690

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

dstansby
Copy link
Contributor

I'm hoping this will unblock the CI. Ideally we would fix this, but I don't think there's an active Cython maintainer to do this, so I guess we'll just skip this for now, and can make a fix a higher priority if a user reports an error.

cc #683

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.70%. Comparing base (5502dc8) to head (b0ea638).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #690      +/-   ##
==========================================
- Coverage   99.81%   99.70%   -0.11%     
==========================================
  Files          62       62              
  Lines        2752     2753       +1     
==========================================
- Hits         2747     2745       -2     
- Misses          5        8       +3     
Files with missing lines Coverage Δ
numcodecs/tests/test_vlen_bytes.py 89.28% <100.00%> (-10.72%) ⬇️

... and 1 file with indirect coverage changes

@dstansby dstansby merged commit f005306 into zarr-developers:main Jan 17, 2025
25 of 26 checks passed
@dstansby dstansby deleted the skip-encode-none branch January 17, 2025 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant