Skip to content
This repository has been archived by the owner on Sep 10, 2024. It is now read-only.

add csharp folder for Jupyter Kernel #22

Merged
merged 1 commit into from
Mar 30, 2016
Merged

Conversation

gwenzek
Copy link

@gwenzek gwenzek commented Jan 29, 2016

I added a 'kernel.json' file in order to facilitate the installation with Jupyter.
I described the installation in the wiki.

@gwenzek
Copy link
Author

gwenzek commented Feb 3, 2016

The build is failing, but I didn't modify any code, so I don't think I'm responsible for this...
Please, could someone look into it ?

@den-run-ai
Copy link
Contributor

@gwenzek @zabirauf looks like nuget is not found during build process:

PackageAssemblyResolverTests.cs(8,7): error CS0246: The type or namespace name `NuGet' could not be found. Are you missing an assembly reference?
            Task "Csc" execution -- FAILED

so most likely something has changed with c#/mono setup in travis ci

@den-run-ai
Copy link
Contributor

but generally +1 on this effort for installing kernelspec

@zabirauf
Copy link
Owner

@gwenzek where will this kernelspec be used in the installation phase?

@gwenzek
Copy link
Author

gwenzek commented Mar 17, 2016

As described in the wiki (linked in my original post) this kernelspec is copied by Jupyter in its directory with the command jupyter kernelspec install

Before that the kernelspec should be modified to point to the installation path of icsharp. Maybe I could add a script that does it based on the cuurent path.

@awb99
Copy link

awb99 commented Mar 17, 2016

Gents! My docker image does install the kernelspec file by COPYING the kernel.json file across. For some reason the jupyter kernelspec install command did not work on my dockers image

@zabirauf
Copy link
Owner

@gwenzek Can you instead change the name of the folder to kernel-spec and send the pull request. Make sure to rebase it so that its only one commit.

Following the folder structure of iFsharp

@gwenzek
Copy link
Author

gwenzek commented Mar 29, 2016

@zabirauf done :-)

@zabirauf zabirauf merged commit c2485ce into zabirauf:master Mar 30, 2016
@zabirauf
Copy link
Owner

@gwenzek Thanks 👍

@kiln1452
Copy link

Hi there,

I have cloned the repository, but the folder 'Engine' is empty. This means that files such as ScriptCs.csproj are missing (and a whole list of others). It's the same issue when I download the Zip. Any ideas?

i.e., The Visual Studio solution is trying the find the following path... (everything up to 'Engine' is there)

Jupyter_d\icsharp-master\icsharp-master\Engine\src\ScriptCs\ScriptCs.csproj

@den-run-ai
Copy link
Contributor

ScriptCs should be downloaded during build process as nuget package, isn't
it? It is external dependency, hence not bundled.

BTW, I made a pip installable clrmagic project to have C# magic cells in
IPython kernel:

https://pypi.python.org/pypi/clrmagic/

On Thu, Nov 10, 2016 at 10:56 AM, kiln1452 notifications@github.com wrote:

Hi there,

I have cloned the repository, but the folder 'Engine' is empty. This means
that files such as ScriptCs.csproj are missing (and a whole list of
others). It's the same issue when I download the Zip. Any ideas?

i.e., The Visual Studio solution is trying the find the following path...
(everything up to 'Engine' is there)

Jupyter_d\icsharp-master\icsharp-master\Engine\src
ScriptCs\ScriptCs.csproj


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#22 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AHgZ5R0Fs_74GATO81ZkYzN17hpLkMT1ks5q80yygaJpZM4HPTAs
.

@zabirauf
Copy link
Owner

@kiln1452 The ScriptCs is a git submodule. You can use the following command to clone which will also pull in the Engine

git clone --recursive https://github.com/zabirauf/icsharp.git

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants