Fix use after free in Main.cpp (issue #846) #871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create c-string to store filepath before concatenating with output message.
|
I don't know if this is the best way to go about doing this, but I wanted to dip my toes into contributing to this project. Let me know if anything needs to change :) |
yvt
requested changes
Nov 27, 2019
Changed variable type to std::string and moved c_str() call
yvt
requested changes
Nov 28, 2019
Removed reference to directory variable
yvt
approved these changes
Nov 29, 2019
Conticop
pushed a commit
to Conticop/OpenSpades
that referenced
this pull request
Dec 23, 2019
* Fix use after free in Main.cpp (issue yvt#846) Create c-string to store filepath before concatenating with output message. * Fix use after free in Main.cpp Changed variable type to std::string and moved c_str() call * Fix use after free in Main.cpp Removed reference to directory variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create c-string to store filepath before concatenating with output message. Fix #846