[DBZ-PGYB] Fixed bug resulting a 0
value in case of pgoutput
#151
+73
−32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Suppose we have a column with a non-basic value like
timestamp
- the code for converting the values here is following:The
else
block above has a missing line which should utilise a converter for the value.Solution
This PR modifies the
PostgresSchema#getTableSchemaBuilder
method to return the defaultTableSchemaBuilder
when the plugin is NOTyboutput
.Additionally, this PR fixes the
else
block inPGTableSchemaBuilder
with the required conversion and adds tests verifying the same forpgoutput
by adding the following logic: